PIC16F785 EEPROM read and write not working

[jmartinstro]

My code for PIC16F785 EEPROM read and write not working.
Compiler 3.225

A code fragment is as follows:

union Calibration
{
int16 Cal_Voltage;
BYTE Ical[4];
}Calib;

void Write_Voltage()
{
BYTE i, Tmp;

Cal_Voltage = 555;

for(i=0;i<4;i++)
{
Tmp = Calib.Ical[i];
WRITE_EEPROM(i,Tmp);
}

for(i=0;i<4;i++)
{
Tmp = READ_EEPROM(i);
Calib.Ical[i] = Tmp;
}

}

This doesn't remember the values on reboot.
I have looked at the assembler output and I am
suspicious the read is failing....

.................... for(i=0;i<4;i++)
0092: CLRF 3D
0093: MOVF 3D,W
0094: SUBLW 03
0095: BTFSS 03.0
0096: GOTO 0A8
.................... {
.................... Tmp = READ_EEPROM(i);
0097: MOVF 3D,W
0098: BSF 03.6
0099: MOVWF 0D
009A: BSF 03.5
009B: BCF 0C.7
009C: BSF 0C.0
009D: BCF 03.5
009E: MOVF 0C,W
009F: BCF 03.6
00A0: MOVWF 3E
.................... Calib.Ical[i] = Tmp;
00A1: MOVLW 48
00A2: ADDWF 3D,W
00A3: MOVWF 04
00A4: MOVF 3E,W
00A5: MOVWF 00
.................... }


If I translate the numbers into registers,
address 009E should read MOVF EEDAT,W
but it seems to be MOVF EECON1,W

But I'm no expert on this chip (right now) and any help is appreciated.

Thanks

Joe

[PCM programmer]

I don't see anything wrong with the read_eeprom() ASM code.
Your union is a little strange. You have a union between a 16-bit
bit value (2 bytes) and an array which is 4 bytes.

You don't really even need the union. You could use the Make8()
and Make16() functions to do this.

[jmartinstro]

[PCM programmer]

I take back what I said about the read_eeprom(). It's using incorrect
register addresses for the 16F785. I installed your version of the
compiler and looked at the .LST file. Also, the write_eeprom() code
is using the wrong register addresses.

Here is a test program with eeprom functions that should work with
your version of the compiler. Use these functions instead of the
built-in functions.

[jmartinstro]