While / For Loops Problem

[flightdecksoft]

Hello,

PIC16F84A

I have written a simple code like this to flash an LED:

void main()
{
while (TRUE)
{
loop();
}
}

int loop(void)
{
OUTPUT_HIGH(PIN_B4);
delay_ms(1000);
OUTPUT_LOW(PIN_B4);
return 0;
}

Now when I compile, I get a warning about the while loop always being true. But when I run the program the LED does not blink. If I remove the while loop, the LED will turn on, then off after one second as expected. Does anyone know why the while loop is not working?

It seems like the delay_ms function is kicking it out of the loop function and back to main, then repeating.

Frustrated,

Jason

[ckielstra]

Your led goes off, but only so short that your eyes don't see it. Add a delay between switching off and on again.

Funny to see that so many people make the same mistake, it must be an error in the human brain. This same question has been on this forum for at least 5 times the last couple of years. Here is a link to a similar question: http://www.ccsinfo.com/forum/viewtopic.php?t=28516

[flightdecksoft]

WOW! Stupid.

Thanks!

[vsmguy]

This is a common mistake in iterative programs.... specially when the person has not been close to hardware recently

I did the same mistake the first time ;)